From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Max Carrara <m.carrara@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH v2 pxar 2/2] decoder: aio: improve performance of async file reads
Date: Fri, 4 Aug 2023 13:32:47 +0200 [thread overview]
Message-ID: <j2ntx2nn2joa3tbnvoyg7cqlcbqv7viharwoude74blqzel2r3@f5db4z7272za> (raw)
In-Reply-To: <20230731133404.859756-2-m.carrara@proxmox.com>
NAK
see comment for the previous v1
TLDR: buffering should be inserted on the consumer side (and our
`Decoder::open` impl should be changed to be for
`Decoder<TokioReader<BufReader<File>>` instead of
`Decoder<TokioReader<File>>`)
(which btw. is a breaking change API-wise)
next prev parent reply other threads:[~2023-08-04 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 13:34 [pbs-devel] [PATCH v2 pxar 1/2] Add `compare-read.rs` to examples and drop feature `async-examples` Max Carrara
2023-07-31 13:34 ` [pbs-devel] [PATCH v2 pxar 2/2] decoder: aio: improve performance of async file reads Max Carrara
2023-07-31 14:57 ` Fabian Grünbichler
2023-07-31 15:14 ` Max Carrara
2023-08-04 11:32 ` Wolfgang Bumiller [this message]
2023-07-31 14:58 ` [pbs-devel] [PATCH v2 pxar 1/2] Add `compare-read.rs` to examples and drop feature `async-examples` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=j2ntx2nn2joa3tbnvoyg7cqlcbqv7viharwoude74blqzel2r3@f5db4z7272za \
--to=w.bumiller@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox