From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied-series: [PATCH backup v2 1/6] replace get(key).is_some() with contains_key()
Date: Fri, 28 Jun 2024 09:36:38 +0200 [thread overview]
Message-ID: <igz6rnzplukuaswj6uq3dospbyy5amckg4ltejw4awspjcd2ec@xuo6sibtyiuv> (raw)
In-Reply-To: <20240626130603.538973-1-m.sandoval@proxmox.com>
applied series, thanks
also followed up with a removing `if .contains_key() .remove() else
bail!()` code pieces with directly calling .remove() and checking for
.is_none() -> bail!()
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-06-28 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 13:05 [pbs-devel] " Maximiliano Sandoval
2024-06-26 13:05 ` [pbs-devel] [PATCH backup v2 2/6] replace get(key).is_none() with !contains_key() Maximiliano Sandoval
2024-06-26 13:06 ` [pbs-devel] [PATCH backup v2 3/6] api: remove use of unnecessary pub(self) Maximiliano Sandoval
2024-06-26 13:06 ` [pbs-devel] [PATCH backup v2 4/6] tools: write multiplication by 01 succinctly Maximiliano Sandoval
2024-06-26 13:06 ` [pbs-devel] [PATCH backup v2 5/6] chunk_store: do not explicitly write implied trait Maximiliano Sandoval
2024-06-26 13:06 ` [pbs-devel] [PATCH backup v2 6/6] tools: add missing cfg(test) macro Maximiliano Sandoval
2024-06-28 7:36 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=igz6rnzplukuaswj6uq3dospbyy5amckg4ltejw4awspjcd2ec@xuo6sibtyiuv \
--to=w.bumiller@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox