public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: superseded [PATCH] fix #7337: Keep track of deep link on OpenID login
Date: Thu, 19 Mar 2026 11:56:40 +0100	[thread overview]
Message-ID: <gzgz4fxjljbtcdgjywzfqgdmn5nb2x3qfjqcox7heiylih2cyn@uqip6kvtyu6i> (raw)
In-Reply-To: <DH6OAK1E3HX0.2OEU9DALCU7JI@proxmox.com>

On Thu, Mar 19, 2026 at 11:05:37AM +0100, Shannon Sterz wrote:
> On Thu Mar 12, 2026 at 3:30 PM CET, Arthur Bied-Charreton wrote:
> > Previously, when opening a deep link without being logged into PBS, the
> > hash was getting lost, redirecting the user to #pbsDashboard instead of
> > /#<deeplink>.
> >
> > Store `window.location.hash` in sessionStorage (per-tab storage) before
> > redirecting to the login URL, and add it to the history after successful
> > login to direct the user to the deeplink they opened.
> >
> > `#pbsDashboard` remains the default redirect if no deeplink is stored.
> >
> > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> > ---
> >  www/LoginView.js | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/www/LoginView.js b/www/LoginView.js
> > index fd9594f6..b72e4223 100644
> > --- a/www/LoginView.js
> > +++ b/www/LoginView.js
> > @@ -48,6 +48,7 @@ Ext.define('PBS.LoginView', {
> >
> >              if (this.getViewModel().data.openid === true) {
> >                  const redirectURL = location.origin;
> > +                sessionStorage.setItem('openid-deeplink', location.hash);
> 
> nit: i think it would be nicer if this was prefixed, so something like
> "pbs-openid-deeplink". also quickly grep-ing over the widget toolkit and
> pbs ui directory, it seems that for local storage we tend to prefer
> camel case, though that isn't consistent.
> 
Ack, thanks for the suggestion! Added in v2:
superseded by:
https://lore.proxmox.com/pbs-devel/20260319105507.266484-1-a.bied-charreton@proxmox.com/T/#u




      reply	other threads:[~2026-03-19 10:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 14:30 Arthur Bied-Charreton
2026-03-19 10:05 ` Shannon Sterz
2026-03-19 10:56   ` Arthur Bied-Charreton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gzgz4fxjljbtcdgjywzfqgdmn5nb2x3qfjqcox7heiylih2cyn@uqip6kvtyu6i \
    --to=a.bied-charreton@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal