From: Fiona Ebner <f.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com, Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] prune-simulator: allow setting a time on which prune happens
Date: Fri, 16 Sep 2022 12:08:41 +0200 [thread overview]
Message-ID: <fffd64d5-3717-dfbe-64b1-1c96f1b3cdef@proxmox.com> (raw)
In-Reply-To: <20220914105039.186907-2-m.heiserer@proxmox.com>
Same nit for the commit title.
Am 14.09.22 um 12:50 schrieb Matthias Heiserer:
> @@ -726,6 +730,15 @@ Ext.onReady(function() {
> padding: '0 0 0 10',
> value: new Date(),
> },
> + {
> + xtype: 'timefield',
> + name: 'currentTime',
> + reference: 'currentTime',
> + fieldLabel: 'Time of prune',
I don't really like using "Time of prune" here, because the setting also
affects the schedule and doesn't feel in line with "Today". How about
"Today's time" or simply "Time"? Or we could use "Current date" and
"Current time".
There's AM/PM times in the drop-down suggestions here, which clashes
with the 24 hour format used in the rest of the simulator. Let's try to
keep it consistent.
> + allowBlank: false,
> + padding: '0 0 0 10',
> + value: new Date(),
> + },
> ],
> },
> ],
next prev parent reply other threads:[~2022-09-16 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 10:50 [pbs-devel] [PATCH proxmox-backup 1/2] prune-simulator: allow setting a date " Matthias Heiserer
2022-09-14 10:50 ` [pbs-devel] [PATCH proxmox-backup 2/2] prune-simulator: allow setting a time " Matthias Heiserer
2022-09-16 10:08 ` Fiona Ebner [this message]
2022-09-19 10:24 ` Matthias Heiserer
2022-09-16 10:08 ` [pbs-devel] [PATCH proxmox-backup 1/2] prune-simulator: allow setting a date " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fffd64d5-3717-dfbe-64b1-1c96f1b3cdef@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox