From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox] pbs api types: add garbage collection cache capacity tuning option
Date: Fri, 4 Apr 2025 13:59:47 +0200 [thread overview]
Message-ID: <ffd6c73b-aa30-4280-bf9e-53a0799babd8@proxmox.com> (raw)
In-Reply-To: <20250403122732.369087-1-c.ebner@proxmox.com>
I left one comment on Patch 4/4 regarding the '(multiples of 1024)' phrasing,
apart from that consider this:
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
--
- Lukas
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-04-04 12:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 12:27 Christian Ebner
2025-04-03 12:27 ` [pbs-devel] [PATCH proxmox-backup 2/4] garbage collection: set phase1 LRU cache capacity by " Christian Ebner
2025-04-03 12:27 ` [pbs-devel] [PATCH proxmox-backup 3/4] ui: expose GC cache capacity in datastore tuning parameters Christian Ebner
2025-04-03 12:27 ` [pbs-devel] [PATCH proxmox-backup 4/4] docs: add description for gc-cache-capacity tuning parameter Christian Ebner
2025-04-04 11:58 ` Lukas Wagner
2025-04-04 12:13 ` Christian Ebner
2025-04-04 12:20 ` Thomas Lamprecht
2025-04-04 12:28 ` Lukas Wagner
2025-04-04 12:37 ` Christian Ebner
2025-04-04 11:59 ` Lukas Wagner [this message]
2025-04-04 13:08 ` [pbs-devel] superseded: [PATCH proxmox] pbs api types: add garbage collection cache capacity tuning option Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffd6c73b-aa30-4280-bf9e-53a0799babd8@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal