From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [RFC PATCH proxmox-backup 0/5] add 'protected' setting for snapshots
Date: Thu, 2 Sep 2021 08:48:14 +0200 [thread overview]
Message-ID: <fefba1f2-9bf7-d3ac-2282-452e2df8739a@proxmox.com> (raw)
In-Reply-To: <1118236361.1959.1630565157734@webmail.proxmox.com>
On 02.09.21 08:45, Dietmar Maurer wrote:
>>> * would we want to protect also against manual removal ? or
>>> 'remove-vanished' on sync?
>>
>> Would make sense as long as we allow to "unprotect" it, that's how we do it for guests
>> in PVE too. IMO it's weird/unexpected to mark it protected and allow some API mechanisms
>> to still remove it.
>
> I would not consider the protected flag for syncs, i.e:
> - do not sync the protected flag itself
That I agree (and I did not meant to suggest otherwise).
> - remove vanished backups even with protected flag set (to be in sync with source)
That I do not agree, if I marked a snapshot explicitly protected, which
is a must for the situation to happen with the first point above in mind
(no syncing of the protection flag itself) then I'm pretty sure that I want
to keep that snapshot no matter what.
next prev parent reply other threads:[~2021-09-02 6:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 6:45 Dietmar Maurer
2021-09-02 6:48 ` Thomas Lamprecht [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-02 7:05 Dietmar Maurer
2021-09-01 8:25 Dominik Csapak
2021-09-02 6:25 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fefba1f2-9bf7-d3ac-2282-452e2df8739a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox