From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 3/3] pbs-api-types: add check for allowed maintenmance mode changes
Date: Mon, 22 Apr 2024 09:20:20 +0200 [thread overview]
Message-ID: <fed046c3-9600-4fa9-b95b-fde872dd3b64@proxmox.com> (raw)
In-Reply-To: <20240419073750.135595-4-dietmar@proxmox.com>
This is a semantic change where the fact that code is touched that's inside a
crate named pbs-api-types is rather an implementation detail, I'd rather use
something like the following as subject:
api: assert that maintenance mode transitions are valid
And having some commit message with some basic reasoning would be also great..
If this was ordered as second patch, i.e., without the new maintenance mode,
we could already apply that and Hannes could add the patch that adds the
maintenance mode to his series, which would be nicer to review and apply
(and IMO a slightly better commit order)
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-04-22 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 7:37 [pbs-devel] [PATCH proxmox-backup v2 0/3] pbs-api-types: new MaintenanceType::Unmount, implement and use set_maintenance_mode Dietmar Maurer
2024-04-19 7:37 ` [pbs-devel] [PATCH proxmox-backup v2 1/3] pbs-api-types: use SchemaDeserializer for maintenance mode Dietmar Maurer
2024-04-19 9:42 ` Christian Ebner
2024-04-19 7:37 ` [pbs-devel] [PATCH proxmox-backup v2 2/3] maintenance: add 'Unmount' maintenance type Dietmar Maurer
2024-04-19 7:37 ` [pbs-devel] [PATCH proxmox-backup v2 3/3] pbs-api-types: add check for allowed maintenmance mode changes Dietmar Maurer
2024-04-22 7:20 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fed046c3-9600-4fa9-b95b-fde872dd3b64@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox