public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup v4 2/2] ui: s3 endpoint: add provider specific quirk selector
Date: Tue, 5 Aug 2025 18:42:06 +0200	[thread overview]
Message-ID: <fe935888-baff-4d42-bb99-900441eec2ee@proxmox.com> (raw)
In-Reply-To: <175440823229.3188344.11268683178675917633.b4-ty@proxmox.com>

On 8/5/25 5:40 PM, Thomas Lamprecht wrote:
> On Tue, 05 Aug 2025 12:51:20 +0200, Christian Ebner wrote:
>> Add an advanced column with a provider specific quirk selector, which
>> allows to set the s3 endpoint accordingly and use the provider
>> specific implementation detail in the s3 client.
>>
>> Clear the value if it is set to the default one, being no quirks.
>>
>> For now only the one If-None-Match http header quirk is available, but
>> this can be extended to a multi selection list if required.
>>
>> [...]
> 
> Applied, with minor label rewording in a follow up, thanks!
> 
> Btw. if we get more than this I'd probably favor moving this to a list of check
> boxes, e.g. nested inside a FieldSet [0] with collapsible disabled and Provider
> Quirks as title, then it would IMO stay a bit more discoverable compared to a
> multi-selection inside a combobox. But only relevant once we get new quirks.
> 
> [0]: https://docs.sencha.com/extjs/7.0.0/classic/Ext.form.FieldSet.html

Okay, thanks for the suggestion!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      reply	other threads:[~2025-08-05 16:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-05 10:51 [pbs-devel] [PATCH proxmox{, -backup} v4 0/3] s3: extend endpoint config and client options by provider-quirks Christian Ebner
2025-08-05 10:51 ` [pbs-devel] [PATCH proxmox v4 1/1] s3 client: extend client config and options by optional provider quirks Christian Ebner
2025-08-05 15:36   ` [pbs-devel] applied: " Thomas Lamprecht
2025-08-05 10:51 ` [pbs-devel] [PATCH proxmox-backup v4 1/2] api: s3 config: allow to update or delete endpoint quirks Christian Ebner
2025-08-05 15:40   ` [pbs-devel] applied: " Thomas Lamprecht
2025-08-05 10:51 ` [pbs-devel] [PATCH proxmox-backup v4 2/2] ui: s3 endpoint: add provider specific quirk selector Christian Ebner
2025-08-05 15:40   ` [pbs-devel] applied: " Thomas Lamprecht
2025-08-05 16:42     ` Christian Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe935888-baff-4d42-bb99-900441eec2ee@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal