From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Nicolas Frey" <n.frey@proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v2 1/2] zfs: status: add `VDevStats` struct instead of 3 optional u64s
Date: Thu, 7 May 2026 11:19:48 +0200 [thread overview]
Message-ID: <fe83db05-d8aa-4fc2-a6b7-58fe31536f83@proxmox.com> (raw)
In-Reply-To: <fa5da821-e64d-42b4-b4a2-83f443bdbfbe@proxmox.com>
Am 07.05.26 um 11:14 schrieb Nicolas Frey:
>> so if we do it, we should also do it there - if we want to avoid that
>> churn, we need to keep the actual members separate.
>>
> Ah thanks! I was unaware that this code was duplicated to
> proxmox-disks. I reckon the place to fix the parsing would rather be
> there then? Or should it be fixed on both sides, until PBS uses
> proxmox-disks?
>
> I don't believe we gain much from pulling this out into a separate
> struct here after thinking about it (especially with what you
> mentioned here), I'll drop it in the next version
I owe moving it out of PBS and replacing it with the refactored out
proxmox-disks one. FWIW, the latter currently has not really that many
(any?) users (i.e., in a bumped package), so now we could still break this
without _that_ much pain, FWIW.
next prev parent reply other threads:[~2026-05-07 9:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 14:16 [PATCH proxmox-backup v2 0/2] fix #7541: zfs status: account for msg directly after status in vdev parser Nicolas Frey
2026-05-05 14:16 ` [PATCH proxmox-backup v2 1/2] zfs: status: add `VDevStats` struct instead of 3 optional u64s Nicolas Frey
2026-05-07 8:00 ` Fabian Grünbichler
2026-05-07 9:16 ` Nicolas Frey
2026-05-07 9:19 ` Thomas Lamprecht [this message]
2026-05-05 14:16 ` [PATCH proxmox-backup v2 2/2] fix #7541: zfs status: account for msg directly after status in vdev parser Nicolas Frey
2026-05-07 8:00 ` Fabian Grünbichler
2026-05-07 9:03 ` Nicolas Frey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe83db05-d8aa-4fc2-a6b7-58fe31536f83@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=n.frey@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox