From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] pxar: create: add entry: fix anchored path pattern matching
Date: Wed, 6 Apr 2022 17:02:45 +0200 [thread overview]
Message-ID: <fe681bc4-8f25-3b8c-091b-3eedd96c8314@proxmox.com> (raw)
In-Reply-To: <20220328111103.136218-1-f.ebner@proxmox.com>
On 28.03.22 13:11, Fabian Ebner wrote:
> Similar to 874bd545 ("pxar: fix anchored exclusion at archive root"),
> but this time for inclusion. Because of the inconsistency, it could
> happen that a file included in generate_directory_file_list() got
> excluded in add_entry(), e.g. with a .pxarexclude file like
>> *
>> !/supposed-to-be-included
>
> Reported-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> An alternative would be to remove the path pattern matching from
> add_entry() entirely. AFAICT, it's only called with the files generated
> by generate_directory_file_list() anyways.
possible, but for now I apply this one to ensure that /some/ fix is in.
> pbs-client/src/pxar/create.rs | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-04-06 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 11:11 [pbs-devel] " Fabian Ebner
2022-04-06 15:02 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe681bc4-8f25-3b8c-091b-3eedd96c8314@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox