From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] ui: tape: mark incomplete media-sets as such
Date: Wed, 8 Nov 2023 16:38:05 +0100 [thread overview]
Message-ID: <fe51cc29-d26f-4394-a702-4704fa9d94dc@proxmox.com> (raw)
In-Reply-To: <20230929085205.1485197-1-d.csapak@proxmox.com>
Am 29/09/2023 um 10:52 schrieb Dominik Csapak:
> by counting the returned tapes and compare it to the sequence number.
> If the tape count is lower than the highest sequence number plus one,
> there must be a tape missing.
>
> Mark it in the text and add the proxmox-warning-row class.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> i opted to not deduplicated the checking logic because it's only three
> lines and we don't have a good place to put it besides Utils.
> If wanted i can ofc do that and send a v2
>
> www/tape/BackupOverview.js | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2023-11-08 15:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 8:52 [pbs-devel] " Dominik Csapak
2023-11-08 15:38 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe51cc29-d26f-4394-a702-4704fa9d94dc@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox