From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: traffic-control: fix `users` field submition
Date: Mon, 24 Nov 2025 15:27:38 +0100 [thread overview]
Message-ID: <fe2c6247-2dd0-4c8e-b636-7c32f0c13b1b@proxmox.com> (raw)
In-Reply-To: <20251124142107.6240-1-h.laimer@proxmox.com>
* ui: traffic-control: fix `users` field submission
not sure how `submition` happened :P
On 11/24/25 15:21, Hannes Laimer wrote:
> We should not submit an empty string when no user is selected, this
> trips up the API endpoint.
>
> Fixes: 7f4f195b ("ui: traffic-control: add users field in edit form and list")
> Reported-by: Robert Obkircher <r.obkircher@proxmox.com>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> www/window/TrafficControlEdit.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/window/TrafficControlEdit.js b/www/window/TrafficControlEdit.js
> index 83b84ff5..7243f5b3 100644
> --- a/www/window/TrafficControlEdit.js
> +++ b/www/window/TrafficControlEdit.js
> @@ -283,6 +283,7 @@ Ext.define('PBS.window.TrafficControlEdit', {
> name: 'users',
> multiSelect: true,
> allowBlank: true,
> + skipEmptyText: true,
> cbind: {
> deleteEmpty: '{!isCreate}',
> },
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-11-24 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 14:21 Hannes Laimer
2025-11-24 14:27 ` Hannes Laimer [this message]
2025-11-24 15:01 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe2c6247-2dd0-4c8e-b636-7c32f0c13b1b@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox