From: Dominik Csapak <d.csapak@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] pbs-datastore: use ConfigVersionCache for datastore
Date: Mon, 28 Feb 2022 07:51:33 +0100 [thread overview]
Message-ID: <fe1bef24-ac58-56a3-9768-672b26492c3b@proxmox.com> (raw)
In-Reply-To: <814473879.3457.1645802718067@webmail.proxmox.com>
On 2/25/22 16:25, Dietmar Maurer wrote:
>> but on the other hand, we now basically create a new datastore object
>> every minute
>
> And you think this is a problem (why)?
it seems unnecessary, and if it was not a problem, why didn't we do it before?
we already read/parsed the config anyway....
i assumed that there was a good reason not to construct a new object
every time, but i did not find it
next prev parent reply other threads:[~2022-02-28 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 15:25 Dietmar Maurer
2022-02-28 6:51 ` Dominik Csapak [this message]
2022-03-01 8:53 ` Thomas Lamprecht
-- strict thread matches above, loose matches on Subject: below --
2022-02-25 14:26 Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe1bef24-ac58-56a3-9768-672b26492c3b@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox