From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-widget-toolkit] auth ui: ldap: fix 'Anonymous Search' being selected if bind-dn is set
Date: Tue, 28 Mar 2023 17:51:36 +0200 [thread overview]
Message-ID: <fdf82765-1875-f351-f07d-6829d01e4dba@proxmox.com> (raw)
In-Reply-To: <20230328151047.860058-1-l.wagner@proxmox.com>
Am 28/03/2023 um 17:10 schrieb Lukas Wagner:
> Only happened on Chrome, weirdly enough.
>
> Fixed by setting a different default value. Side-effect: When creating a
> new realm, the checkbox is not selected now.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> src/window/AuthEditLDAP.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
> index 3e8ce88..849be99 100644
> --- a/src/window/AuthEditLDAP.js
> +++ b/src/window/AuthEditLDAP.js
> @@ -6,7 +6,7 @@ Ext.define('Proxmox.panel.LDAPInputPanelViewModel', {
>
> data: {
> mode: 'ldap',
> - anonymous_search: 1,
> + anonymous_search: 0,
> },
>
> formulas: {
As written off-list, so just for reference:
Replaced this by keeping the default but setting the view model data explicitly
in onSetValues (i.e., on edit):
https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=4d3a18dfc3a37520f0eb82fec120fcc0da625583
While that may not be the best fix, it's a bit less brittle & subtle, and avoids
the need to change user facing behavior for a framerwork/browser limitation/bug.
prev parent reply other threads:[~2023-03-28 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 15:10 Lukas Wagner
2023-03-28 15:51 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdf82765-1875-f351-f07d-6829d01e4dba@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox