From: Stefan Hanreich <s.hanreich@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Thomas Lamprecht" <t.lamprecht@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-network-interface-pinning 1/1] initial commit
Date: Wed, 30 Jul 2025 15:35:40 +0200 [thread overview]
Message-ID: <fd1a6cc2-8dbf-48f2-bd60-a7e6d7d1562e@proxmox.com> (raw)
In-Reply-To: <1753882075.ft5uga1dqu.astroid@yuna.none>
On 7/30/25 3:30 PM, Fabian Grünbichler wrote:
[snip]
>>> I assume, we would then install the standalone package by default in PVE?
>>
>> That's the only small "ugliness" there is with this approach, as it would
>> not be required per se.
>>
>> The alternative I see is that both life in /usr/bin, either with
>> "pve" and "proxmox" prefix in the name, respectively, or under the same
>> name but with conflicts on packaging level and this package here being
>> added only as Recommended for PBS/PDM/PMG to allow co-installation.
>>
>> tbh. I'm not opposed of either variant, CC'in Fabian, maybe he can act
>> as tie breaker here.
>
> I think installing the rust one always is the simplest solution, even if
> it is basically a wrapper doing nothing except forwarding the invocation
> on systems with PVE installed.
>
> we could also solve this cleanly on the packaging level, but all the
> variants I can come up with[0] are more involved - and at some point we
> will probably want to drop the PVE specific one anyway, i.e., when we
> switch the network config parsing there over to the Rust-based one one
> it reaches feature parity ;)
>
> 0: alternatives preferring the PVE one, diverting by the PVE package, ..
Yeh, I'm also gravitating towards that solution, imo the easiest path
after all.
So:
pve-network-interface-pinning in /usr/libexec/proxmox
proxmox-network-interface-pinning in /usr/bin
I'll send a v2 for this series, as well as a new patch for pve-manager -
unless there are any objections? @Thomas
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-30 13:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 16:56 [pbs-devel] [PATCH proxmox{-ve-rs, , -backup, -firewall, -network-interface-pinning} 0/8] proxmox-network-interface-pinning Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox-ve-rs 1/1] host: network: move to proxmox-network-api Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox 1/3] pbs-api-types: use proxmox-network-api types Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox 2/3] proxmox-network-api: use ip link for querying interface information Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox 3/3] network-api: add rename_interfaces method Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox-backup 1/2] config: network: move to proxmox-network-api Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox-backup 2/2] metric_collection: use ip link for determining the type of interfaces Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox-firewall 1/1] firewall: config: use proxmox-network-api Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox-network-interface-pinning 1/1] initial commit Stefan Hanreich
2025-07-30 13:07 ` Thomas Lamprecht
2025-07-30 13:14 ` Stefan Hanreich
2025-07-30 13:24 ` Thomas Lamprecht
2025-07-30 13:30 ` Fabian Grünbichler
2025-07-30 13:35 ` Stefan Hanreich [this message]
2025-07-30 13:42 ` Thomas Lamprecht
2025-07-30 14:37 ` [pbs-devel] superseded: [PATCH proxmox{-ve-rs, , -backup, -firewall, -network-interface-pinning} 0/8] proxmox-network-interface-pinning Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd1a6cc2-8dbf-48f2-bd60-a7e6d7d1562e@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox