From: Dominik Csapak <d.csapak@proxmox.com>
To: Jakob-Tobias Winter <tobias@stuttgart.de>, pbs-devel@lists.proxmox.com
Subject: Re: [RFC PATCH proxmox-backup 4/4] ui: tape restore: add selector for additional drives
Date: Wed, 11 Nov 2026 14:19:06 +0100 [thread overview]
Message-ID: <fd14e8e1-0487-4f46-925a-2e4adc13184d@proxmox.com> (raw)
In-Reply-To: <20261106133826.1692620-6-tobias@stuttgart.de>
when changing to 'drives' instead, this patch
would become just the change from `name: 'drive'` to `name: 'drives'`
and add the multiselect, no?
On 11/6/26 2:38 PM, Jakob-Tobias Winter wrote:
> Allow choosing up to three more drives for a tape restore, to read
> several media in parallel.
>
> Signed-off-by: Jakob-Tobias Winter <tobias@stuttgart.de>
> ---
> www/tape/window/TapeRestore.js | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
> index 8ee4f17a9..d28d2f242 100644
> --- a/www/tape/window/TapeRestore.js
> +++ b/www/tape/window/TapeRestore.js
> @@ -374,6 +374,11 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
> let controller = me.up('window').getController();
> let vm = controller.getViewModel();
> let datastores = [];
> +
> + let additionalDrives = values['additional-drives'];
> + if (!additionalDrives || additionalDrives.length === 0) {
> + delete values['additional-drives'];
> + }
> if (values.store.toString() !== '') {
> let target = values.store.toString();
> delete values.store;
> @@ -479,6 +484,16 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
> fieldLabel: gettext('Drive'),
> labelWidth: 120,
> },
> + {
> + xtype: 'pbsDriveSelector',
> + name: 'additional-drives',
> + fieldLabel: gettext('Additional Drives'),
> + labelWidth: 120,
> + multiSelect: true,
> + allowBlank: true,
> + skipEmptyText: true,
> + emptyText: gettext('None'),
> + },
> {
> xtype: 'pbsDataStoreSelector',
> name: 'store',
next prev parent reply other threads:[~2026-11-11 13:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 13:38 [RFC PATCH proxmox-backup 0/4] fix 7333 use multiple tape drives for restoring Jakob-Tobias Winter
2026-11-06 13:38 ` [RFC PATCH proxmox-backup 1/4] tape: drive: add a pool to use several drives for one task Jakob-Tobias Winter
2026-11-10 15:05 ` Dominik Csapak
2026-11-06 13:38 ` [RFC PATCH proxmox-backup 2/4] tape: restore: use a drive pool for the selective restore Jakob-Tobias Winter
2026-11-11 12:59 ` Dominik Csapak
2026-11-06 13:38 ` [RFC PATCH proxmox-backup 3/4] close #7333: tape: restore: allow using several drives in parallel Jakob-Tobias Winter
2026-11-11 13:18 ` Dominik Csapak
2026-11-06 13:38 ` [RFC PATCH proxmox-backup 4/4] ui: tape restore: add selector for additional drives Jakob-Tobias Winter
2026-11-11 13:19 ` Dominik Csapak [this message]
2026-11-10 13:15 ` [RFC PATCH proxmox-backup 0/4] fix 7333 use multiple tape drives for restoring Dominik Csapak
2026-11-10 15:43 ` Jakob-Tobias Winter
2026-11-11 13:38 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd14e8e1-0487-4f46-925a-2e4adc13184d@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=tobias@stuttgart.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox