From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Dominik Csapak" <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] pull: properly skip missing snapshots
Date: Wed, 27 Nov 2024 11:46:08 +0100 [thread overview]
Message-ID: <fc39d31b-ea7e-4d30-bf47-0449ff987ec4@proxmox.com> (raw)
In-Reply-To: <1732698965.5ul13djmpt.astroid@yuna.none>
Am 27.11.24 um 10:17 schrieb Fabian Grünbichler:
> handling ENOENT might be nice as additional safeguard, not sure if we
> properly bubble that up atm though..
Yes, would be nice(r), but it indeed seems like the underlying
BackupDir::load_blob from pbs_datastore hides the actual error.
We should switch that over to use anyhow's context and probably drop the
try_block; not really useful here.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-27 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 8:26 Fabian Grünbichler
2024-11-27 9:05 ` Dominik Csapak
2024-11-27 9:17 ` Fabian Grünbichler
2024-11-27 10:46 ` Thomas Lamprecht [this message]
2024-11-27 9:05 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc39d31b-ea7e-4d30-bf47-0449ff987ec4@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox