Re: [pbs-devel] [PATCH proxmox-backup] fix #5217: api: send missing header when upgrading to HTTP/2

[Max Carrara <m.carrara@proxmox.com>]

On 2/28/24 19:03, Thomas Lamprecht wrote:
> Am 28/02/2024 um 17:20 schrieb Max Carrara:
>> Caddy therefore does not deviate from the HTTP/1.1 and HTTP/2
>> specifications; neither to we. I therefore conclude that it's best to
>> just include the header in this specific response anyway, as no harm
>> is done by doing so.
>>
> 
> can be fine, but is there any discussion about this from Caddy's site?

I haven't found anything, no.

> 
> As while we can take this in and PBS should work with Caddy in-between,
> other HTTP/2 daemons that follow spec while not having that header
> still won't work.
> So, if there isn't any issue tracker entry for this at caddy's side it
> might be worth opening one even if we apply this here, and if there's
> an existing issue then referencing it here would be great.

I've opened a more detailed issue over on Caddy's GitHub where I've
described pretty much everything I had discovered [0]. Most of the
information there regarding the RFC specs and whatnot are already in the
commit message of the patch.

I'd say we wait a little bit and see what the Caddy folks' opinions are on
this before we apply this patch in case some additional things / infos turn
up that might be of relevance.

In either case I'll send in a v2 with an updated commit message once there's
been some progress in that regard. Will reference the issue in the message
as well (and might reword some things, now that I've read it again).

[0]: https://github.com/caddyserver/caddy/issues/6134