public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Maximiliano Sandoval R <m.sandoval@proxmox.com>
Subject: Re: [pbs-devel] [PATCH backup 1/2] debug: Show if chunks are compressed during inspect
Date: Tue, 7 Nov 2023 10:13:08 +0100	[thread overview]
Message-ID: <fb9c5807-5e32-411b-950a-56676af48069@proxmox.com> (raw)
In-Reply-To: <20231103134654.130555-1-m.sandoval@proxmox.com>

Am 03/11/2023 um 14:46 schrieb Maximiliano Sandoval R:
> Signed-off-by: Maximiliano Sandoval R <m.sandoval@proxmox.com>
> ---
>  src/bin/proxmox_backup_debug/inspect.rs | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/bin/proxmox_backup_debug/inspect.rs b/src/bin/proxmox_backup_debug/inspect.rs
> index 29265e26..f3a13f3d 100644
> --- a/src/bin/proxmox_backup_debug/inspect.rs
> +++ b/src/bin/proxmox_backup_debug/inspect.rs
> @@ -190,17 +190,20 @@ fn inspect_chunk(
>          Some(references) => json!({
>              "crc": crc_status,
>              "encryption": blob.crypt_mode()?,
> +            "is_compressed": blob.is_compressed(),

please use kebab-case, as the entry below does...

>              "referenced-by": references
>          }),
>          None => json!({
>               "crc": crc_status,
>               "encryption": blob.crypt_mode()?,
> +             "is_compressed": blob.is_compressed(),

same

>          }),
>      };
>  
>      if output_format == "text" {
>          println!("CRC: {}", val["crc"]);
>          println!("encryption: {}", val["encryption"]);
> +        println!("is_compressed: {}", val["is_compressed"]);

same

>          if let Some(refs) = val["referenced-by"].as_array() {
>              println!("referenced by:");
>              for reference in refs {





      parent reply	other threads:[~2023-11-07  9:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-03 13:46 Maximiliano Sandoval R
2023-11-03 13:46 ` [pbs-devel] [PATCH backup 2/2] debug: Show chunk size while inspecting Maximiliano Sandoval R
2023-11-07  9:13 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb9c5807-5e32-411b-950a-56676af48069@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal