From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked
Date: Tue, 24 Oct 2023 11:54:29 +0200 [thread overview]
Message-ID: <fb844e0d-26ad-4a7c-a8e5-5d99c29c7b01@proxmox.com> (raw)
In-Reply-To: <54f6b050-02ce-4443-a3f3-e28ee2b875bd@proxmox.com>
On 10/24/23 11:18, Lukas Wagner wrote:
> Hi,
>
> Also, some higher-level comments:
>
> The include/exclude behavior seems not super intuitive to me, as it
> appears that the behavior depends on the order of the group-filter
> config entries - e.g. "include all VMs" followed by "exclude VM 190"
> has a different behavior than the other way round. In the GUI this is
> not super obvious, and also there is no way to reorder the matching
> rules.
>
> I would probably do it this way:
>
> no group-filters defined -> everything is included
> only including filter -> only groups matching the filter(s) are
> included
> only excluding filter -> all groups but the matching ones are
> included
I am not 100% sure how I feel about including all as a starting point
for exclusion filter. While I understand the intuitive benefit, it
also may make the process more error prone, since removing 1 include
filter may change everything to include all. User might not think of that.
> including and excluding -> first compute included groups, then subtract
> excluded ones
>
I considered this. The reason why I decided for only one list is
because it enables user to make more sophisticated rules more easily.
Having 2 lists that get processed after each other can make it much
harder to filter on a complex setup.
> Ideally, this behavior should be
> a.) obvious in the GUI
> b.) documented in the docs, with a few concrete examples
>
I see what I can do about explaining this behaviour better in the GUI
and how to extend the documentation.
next prev parent reply other threads:[~2023-10-24 9:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 15:42 [pbs-devel] [PATCH proxmox-backup 0/3] fix #4315: datastore: Exclude entries from sync Philipp Hufnagl
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 1/3] fix #4315: jobs: modify GroupFilter so include/exclude is tracked Philipp Hufnagl
2023-10-24 9:18 ` Lukas Wagner
2023-10-24 9:54 ` Philipp Hufnagl [this message]
2023-10-24 10:43 ` Lukas Wagner
2023-10-24 14:32 ` Philipp Hufnagl
2023-10-25 13:33 ` Thomas Lamprecht
2023-10-25 15:07 ` Philipp Hufnagl
2023-10-25 15:45 ` Thomas Lamprecht
2023-11-07 7:43 ` Wolfgang Bumiller
2023-11-07 7:55 ` Thomas Lamprecht
2023-11-07 8:26 ` Wolfgang Bumiller
2023-11-07 9:01 ` Dominik Csapak
2023-11-07 11:10 ` Thomas Lamprecht
2023-11-07 11:07 ` Thomas Lamprecht
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 2/3] ui: Show if Filter includes or excludes Philipp Hufnagl
2023-10-24 12:20 ` Lukas Wagner
2023-10-24 12:27 ` Lukas Wagner
2023-10-24 12:36 ` Philipp Hufnagl
2023-10-24 14:09 ` Philipp Hufnagl
2023-10-24 14:12 ` Lukas Wagner
2023-10-27 9:29 ` Thomas Lamprecht
2023-10-23 15:43 ` [pbs-devel] [PATCH proxmox-backup 3/3] docs: document new include/exclude paramenter Philipp Hufnagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb844e0d-26ad-4a7c-a8e5-5d99c29c7b01@proxmox.com \
--to=p.hufnagl@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox