public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] config: add default datastore creation function
Date: Mon, 13 May 2024 10:52:05 +0200	[thread overview]
Message-ID: <faa5501c-ee7b-48f1-96b7-5c01017e1fc0@proxmox.com> (raw)
In-Reply-To: <20240503142933.171798-1-g.goller@proxmox.com>

On 5/3/24 16:29, Gabriel Goller wrote:
> Add a function to create a default datastore. This datastore will have a
> default prune-job with a daily schedule and a gc-job with a daily
> schedule as well.
> 

Tested this and found that while the default prune and 
garbage-collection jobs are created when creating the datastore via the 
WebUI or as part of a disk create transaction, this is not true if done 
via the CLI or API for the datastore create itself, by e.g. 
`proxmox-backup-manager datastore create <name> <path>`.
Also, this default behavior should be documented.

So similar to what Fabian already commented to patches from my side:
https://lists.proxmox.com/pipermail/pbs-devel/2023-November/007361.html



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2024-05-13  8:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03 14:29 Gabriel Goller
2024-05-03 14:29 ` [pbs-devel] [PATCH proxmox-backup 2/2] disks: unify default datastore creation Gabriel Goller
2024-05-03 14:32 ` [pbs-devel] [PATCH proxmox-backup 1/2] config: add default datastore creation function Gabriel Goller
2024-05-03 14:49   ` Christian Ebner
2024-05-03 15:31     ` Christian Ebner
2024-05-13  8:52 ` Christian Ebner [this message]
2024-05-13  9:31   ` Gabriel Goller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=faa5501c-ee7b-48f1-96b7-5c01017e1fc0@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=g.goller@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal