From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/2] tools/logrotate: fix compression logic
Date: Wed, 28 Oct 2020 18:51:21 +0100 [thread overview]
Message-ID: <fa148e93-fff4-85a7-d0bc-3bb4f0a8c896@proxmox.com> (raw)
In-Reply-To: <20201028095801.1737-1-d.csapak@proxmox.com>
On 28.10.20 10:58, Dominik Csapak wrote:
> we never actually compressed any files, since we only looked at
> the extension:
> * if it was 'zst' (which was always true for newly rotated files), we
> would not compress it
> * even if it was not 'zst', we compressed it inplace, never adding '.zst'
> (possibly compressing them multiple times as zstd)
>
> now we add new rotated files simply as '.X' and add a 'target' to the
> compress fn, where we rename it to (but now we have to unlink the source
> path)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/tools/logrotate.rs | 37 +++++++++++++++++++------------------
> 1 file changed, 19 insertions(+), 18 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-10-28 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 9:58 [pbs-devel] " Dominik Csapak
2020-10-28 9:58 ` [pbs-devel] [RFC PATCH proxmox-backup 2/2] server/worker_task: simplify task log writing Dominik Csapak
2020-10-28 17:57 ` Thomas Lamprecht
2020-10-28 17:51 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa148e93-fff4-85a7-d0bc-3bb4f0a8c896@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox