From: Hannes Laimer <h.laimer@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] verify: include namespace for group in log
Date: Thu, 20 Nov 2025 14:21:52 +0100 [thread overview]
Message-ID: <f936ddbe-c105-45c3-a769-abaf0d292c28@proxmox.com> (raw)
In-Reply-To: <1763644154.hvdkxonehx.astroid@yuna.none>
On 11/20/25 14:09, Fabian Grünbichler wrote:
> On November 20, 2025 12:52 pm, Hannes Laimer wrote:
>> Groups with the same name in different namespaces couldn't really be told
>> appart. This solves this by also printing the namespace of a group to the
>> log.
>>
>> This came up in support.
>>
>> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
>> ---
>> not super sure about the formatting, didn't want to change the
>> <datastore>:<group> format we use a lot. don't log for snapshots as that
>> would potentially add a lot of output that doesn't add much information
>>
>> src/backup/verify.rs | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/backup/verify.rs b/src/backup/verify.rs
>> index 734c7b30..10f54c28 100644
>> --- a/src/backup/verify.rs
>> +++ b/src/backup/verify.rs
>> @@ -500,8 +500,15 @@ impl VerifyWorker {
>> };
>>
>> let snapshot_count = list.len();
>> + let ns = group.backup_ns();
>> + let ns_str = if ns.is_root() {
>> + "/".to_string()
>> + } else {
>> + ns.to_string()
>> + };
>> info!(
>> - "verify group {}:{} ({} snapshots)",
>> + "verify group in '{}' - {}:{} ({} snapshots)",
>> + ns_str,
>
> when syncing, we log the namespace once at the start/end, should follow
> this approach here as well for consistency?
>
> nested namespace names can get quite long..
>
IIRC we sort just by the groups, but if the namespaces would be done in
blocks, sure. would cut down verbosity by quite a bit
>> self.datastore.name(),
>> group.group(),
>> snapshot_count
>> --
>> 2.47.3
>>
>>
>>
>> _______________________________________________
>> pbs-devel mailing list
>> pbs-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>>
>>
>>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-11-20 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 11:52 Hannes Laimer
2025-11-20 12:34 ` Michael Köppl
2025-11-20 13:09 ` Fabian Grünbichler
2025-11-20 13:21 ` Hannes Laimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f936ddbe-c105-45c3-a769-abaf0d292c28@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox