Re: [PATCH backup v4 0/4] fix #7054: client: remove trailing newlines from credentials

[Christian Ebner <c.ebner@proxmox.com>]

On 7/6/26 10:03 AM, Maximiliano Sandoval wrote:
> See the first commit for more details.
> 
> This was tested with proxmox-backup-client making a login/backup using different
> credentials with and without newlines. The commands were similar to the
> systemd-run commands at the Backup Client Usage docs.
> 
> I did not find a way to create the keyfile with newlines in its password using
> proxmox-backup-client since it reads from the tty stdin, but surely it could be
> created manually. Perhaps it is safe-ish to also remove trailing control
> characters from the encryption password but this seems a safer approach for now.
> 
> Differences from v3:
>   - Move trim_end calls to get_password, get_repository, get_fingerprint
>   - Remove "in general" from the documentation
>   - Rename get_secret_impl to get_secret_string
> 
> Diferences from v2:
>   - Reworded commit messages following feedback form v1.
> 
> Diferences from v1:
>   - Always do an extra allocation to keep the code clean
>   - Rename password to blob
>   - Only strip newlines on passwords
> 

Thanks for the new version of the patches, code is cleaner now IMO. 
Tested newlines and/or whitespaces are stripped as expected by adapting 
the respective systemd credentials files.

Consider:

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>