From: Christian Ebner <c.ebner@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH v3 proxmox 1/4] http: client: make https connector generic over resolver
Date: Tue, 8 Apr 2025 16:21:30 +0200 [thread overview]
Message-ID: <f8dbd4bc-294c-47e8-9ecc-923ee548cf44@proxmox.com> (raw)
In-Reply-To: <e72lwy5ajpmvq36hqo4egzvbg47i5wu3o7amehtitw7myu3ryv@xvhz2igtj3iw>
On 4/8/25 16:06, Wolfgang Bumiller wrote:
> One tiny nit...
>
> On Tue, Apr 08, 2025 at 02:38:08PM +0200, Christian Ebner wrote:
>>
>> #[derive(Clone)]
>> -pub struct HttpsConnector {
>> - connector: HttpConnector,
>> +pub struct HttpsConnector<T> {
>
> Generics on structs can have defaults, so if we use
>
> struct HttpsConnctor<T = GaiResolver> {}
>
> then even the old pbs code builds.
> While it is *still* technically a breaking change, other users of this
> crate *likely* can do with just a dependency bump.
>
> (But at least it *sort of* documents what the heck this `T` is supposed
> to be on a type otherwise completely devoid of documentation ;-) )
A great! Will add the default type for the generic and add the docs as
requested by Lukas in the other response.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-04-08 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 12:38 [pbs-devel] [PATCH v3 proxmox proxmox-backup 0/4] fix 4788: statically linked proxmox-backup-client Christian Ebner
2025-04-08 12:38 ` [pbs-devel] [PATCH v3 proxmox 1/4] http: client: make https connector generic over resolver Christian Ebner
2025-04-08 14:06 ` Wolfgang Bumiller
2025-04-08 14:21 ` Christian Ebner [this message]
2025-04-08 12:38 ` [pbs-devel] [PATCH v3 proxmox-backup 2/4] fix: 4788: Makefile: target for statically linked client binary Christian Ebner
2025-04-08 12:38 ` [pbs-devel] [PATCH v3 proxmox-backup 3/4] Makefile: switch path based on build mode and target Christian Ebner
2025-04-08 12:38 ` [pbs-devel] [PATCH v3 proxmox-backup 4/4] client: http: Use custom resolver for statically linked binary Christian Ebner
2025-04-08 13:14 ` [pbs-devel] [PATCH v3 proxmox proxmox-backup 0/4] fix 4788: statically linked proxmox-backup-client Lukas Wagner
2025-04-08 14:19 ` Christian Ebner
2025-04-08 15:06 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8dbd4bc-294c-47e8-9ecc-923ee548cf44@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal