Re: [pbs-devel] [PATCH v3 proxmox-widget-toolbox 4/9] safe-destroy: add possibility to show a small note

[Dominik Csapak <d.csapak@proxmox.com>]

comment inline

On 8/28/20 10:46 AM, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> add field to set the note and add ui-container for displaying it
> 
>   src/window/SafeDestroy.js | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
> 
> diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js
> index a6ad458..0027e98 100644
> --- a/src/window/SafeDestroy.js
> +++ b/src/window/SafeDestroy.js
> @@ -21,6 +21,7 @@ Ext.define('Proxmox.window.SafeDestroy', {
>   	    purgeable: false,
>   	},
>   	url: undefined,
> +	note: undefined,
>   	taskName: undefined,
>   	params: {},
>       },
> @@ -138,6 +139,22 @@ Ext.define('Proxmox.window.SafeDestroy', {
>   			'data-qtip': gettext('Remove from replication and backup jobs'),
>   		    },
>   		},
> +		{
> +		    xtype: 'container',
> +		    reference: 'noteContainer',
> +		    flex: 1,
> +		    layout: {
> +			type: 'vbox',
> +			align: 'middle',
> +		    },
> +		    height: 25,
> +		    items: [
> +			{
> +			    xtype: 'component',
> +			    reference: 'noteCmp',
> +			},
> +		    ],
> +		},

2 things here:
* if i have a very long message, it gets truncated and
is not completely visible anymore. since we often
have that text in a 'gettext' where we do not often
check for the length, this could be a problem

* i would set it to hidden by default

>   	    ],
>   	},
>       ],
> @@ -161,8 +178,17 @@ Ext.define('Proxmox.window.SafeDestroy', {
>   	}
>   
>   	const messageCmp = me.lookupReference('messageCmp');
> +	const noteCmp = me.lookupReference('noteCmp');
>   	let msg;
>   
> +	if (Ext.isDefined(me.getNote())) {
> +	    noteCmp.setHtml(`<small>${me.getNote()}</small>`);
> +	} else {
> +	    const noteContainer = me.lookupReference('noteContainer');
> +	    noteContainer.setDisabled(true);
> +	    noteContainer.setHidden(true);
> +	}

and here only make it visible if getNote is defined.
this makes the code a litte more compact
e.g.

let note = me.getNote();
if (Ext.isDefined(note)) {
     ...setHtml...
     ...setHidden(false)...
}

> +
>   	if (Ext.isDefined(me.getTaskName())) {
>   	    msg = Proxmox.Utils.format_task_description(me.getTaskName(), item.id);
>   	    messageCmp.setHtml(msg);
>