From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [pve-devel] [PATCH/RFC v2 common 6/7] allow workers to count warnings and finish tasks in a WARNINGS state
Date: Fri, 23 Apr 2021 14:36:32 +0200 [thread overview]
Message-ID: <f76f0950-a394-420c-309b-365718e4337b@proxmox.com> (raw)
In-Reply-To: <20210409084436.2454-7-f.ebner@proxmox.com>
On 09.04.21 10:44, Fabian Ebner wrote:
> as is already supported by the UI (and PBS).
>
> A nice bonus is that warn() can be used by both workers and non-workers. For
> workers, the output is redirected/duplicated as set up by {fork,tee}_worker(),
> and non-erroring workers that issued a warning will end in a WARNINGS state.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Changes from v1:
> * use chomp in warn(), so it can also be called with newline-terminated
> strings
>
> src/PVE/RESTEnvironment.pm | 22 ++++++++++++++++++++--
> src/PVE/Tools.pm | 2 ++
> 2 files changed, 22 insertions(+), 2 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2021-04-23 12:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 8:44 [pbs-devel] [PATCH-SERIES v2] improve warnings handling in UI and add to PVE Fabian Ebner
2021-04-09 8:44 ` [pbs-devel] [PATCH v2 widget-toolkit 1/7] task status: create helper for formatting Fabian Ebner
2021-04-23 12:54 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2021-04-09 8:44 ` [pbs-devel] [PATCH v2 widget-toolkit 2/7] format task status: rename variable Fabian Ebner
2021-04-23 12:54 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2021-04-09 8:44 ` [pbs-devel] [PATCH v2 widget-toolkit 3/7] format task status: improve replace() usage Fabian Ebner
2021-04-23 12:54 ` [pbs-devel] applied: [pve-devel] " Thomas Lamprecht
2021-04-09 8:44 ` [pbs-devel] [PATCH v2 proxmox-backup 4/7] ui: tasks: use format_task_status Fabian Ebner
2021-04-09 8:44 ` [pbs-devel] [PATCH v2 manager 5/7] ui: cluster task log: handle warnings like the node task log does Fabian Ebner
2021-04-09 8:44 ` [pbs-devel] [PATCH/RFC v2 common 6/7] allow workers to count warnings and finish tasks in a WARNINGS state Fabian Ebner
2021-04-23 12:36 ` Thomas Lamprecht [this message]
2021-04-09 8:44 ` [pbs-devel] [PATCH/RFC v2 container 7/7] restore: sanitize config: use new warn() function Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f76f0950-a394-420c-309b-365718e4337b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox