Re: [pbs-devel] [PATCH proxmox v2 2/3] pbs-api-types: jobs: add {read, verify}-threads to VerificationJobConfig

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 06.11.25 um 17:13 schrieb Nicolas Frey:
> controls the number of parallel threads to read/verify chunks.
> 

Any thoughts on having these options (also) in the datastore config's tuning
options? No hard feelings for that, just something I asked myself. Can be fine
to not do now (it's easier to add things later than having to remove them again),
but might still warrant adding some reasoning for choosing the verification
config here in the commit message, at least if there's the need for a v3. Could
be fleeced in on applying otherwise.

> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>  pbs-api-types/src/jobs.rs | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/pbs-api-types/src/jobs.rs b/pbs-api-types/src/jobs.rs
> index 4dbbef2b..2b9cef38 100644
> --- a/pbs-api-types/src/jobs.rs
> +++ b/pbs-api-types/src/jobs.rs
> @@ -203,6 +203,14 @@ pub const VERIFICATION_OUTDATED_AFTER_SCHEMA: Schema =
>              optional: true,
>              schema: crate::NS_MAX_DEPTH_SCHEMA,
>          },
> +        "read-threads": {
> +            schema: crate::READ_THREADS_SCHEMA,
> +            optional: true,
> +        },
> +        "verify-threads": {
> +            schema: crate::VERIFY_THREADS_SCHEMA,
> +            optional: true,
> +        },
>      }
>  )]
>  #[derive(Serialize, Deserialize, Updater, Clone, PartialEq)]
> @@ -233,6 +241,12 @@ pub struct VerificationJobConfig {
>      /// how deep the verify should go from the `ns` level downwards. Passing 0 verifies only the
>      /// snapshots on the same level as the passed `ns`, or the datastore root if none.
>      pub max_depth: Option<usize>,
> +    /// The number of read threads to use for the job.
> +    #[serde(skip_serializing_if = "Option::is_none")]
> +    pub read_threads: Option<usize>,
> +    /// The number of verification threads to use for the job.
> +    #[serde(skip_serializing_if = "Option::is_none")]
> +    pub verify_threads: Option<usize>,
>  }
>  
>  impl VerificationJobConfig {



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel