From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Shannon Sterz <s.sterz@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] datastore/api: add error message on failed removal due to old locking
Date: Thu, 3 Apr 2025 18:07:33 +0200 [thread overview]
Message-ID: <f633df2c-11e2-45ce-a164-1102ac6830e1@proxmox.com> (raw)
In-Reply-To: <20250403132301.352771-1-s.sterz@proxmox.com>
Am 03.04.25 um 15:23 schrieb Shannon Sterz:
> group or namespace removal can fail if the old locking mechanism is
> still in use, as it is unsafe to properly clean up in that scenario.
> return an error message that explains how to rectify that situation.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> pbs-datastore/src/backup_info.rs | 2 +-
> pbs-datastore/src/datastore.rs | 6 +++++-
> src/api2/admin/datastore.rs | 22 ++++++++++++++++------
> src/api2/admin/namespace.rs | 8 +++++++-
> 4 files changed, 29 insertions(+), 9 deletions(-)
>
>
applied, with some fine-tuning of the error message (mostly adding "if you're
an admin"), thanks!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-04-03 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 13:23 [pbs-devel] " Shannon Sterz
2025-04-03 16:07 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f633df2c-11e2-45ce-a164-1102ac6830e1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal