Re: [pbs-devel] [RFC v2 proxmox-backup 31/36] specs: add backup detection mode specification

[Christian Ebner <c.ebner@proxmox.com>]

On 3/12/24 13:31, Christian Ebner wrote:
> On 3/12/24 13:17, Fabian Grünbichler wrote:
>> I already had this question in the other patch that uses this, but do we
>> need this kind of control? wouldn't a third value MetadataNoReuse (name
>> tbd ;)) to force a "cut" be enough (e.g., if I am either afraid that the
>> re-use might have bugs, or I want to reset the re-use / chunk
>> boundaries)?
> 
> No, this is not strictly necessary if we do not want to limit the 
> metadata change detection to specific archives for a multi-archive 
> backup. Should I remove this? I just considered this a nice to have.
> 

Reduced this to the 2 enum variants for now:
BackupDetectionMode::Data
BackupDetectionMode::Metadata

Maybe it makes sense to go in the other direction here and introduce an 
additional flag `--split-archive` or the like, and make this a 
requirement for setting the `--change-detection-mode` flag?
This would logically separate the splitting of the archive in metadata 
and payload streams during backup creation and decouple it from the 
actual change detection.