From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox] schema: removed excessive newlines in error messages
Date: Mon, 23 Oct 2023 09:51:19 +0200 [thread overview]
Message-ID: <f5bde31e-1fbd-4b82-be21-a8c742781fea@proxmox.com> (raw)
In-Reply-To: <ef964fed-a762-47de-afda-419789beccf4@proxmox.com>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
On 10/18/23 19:22, Thomas Lamprecht wrote:
> [..]
> The only thing, from top of my head, speaking against doing 1. at all would
> be that it's making parsing a bit harder, but tbh., we never guaranteed
> error message stability, and if one depends on such stuff they should use
> the API – so not seeing that as a blocker.
>
> What do you think?
Yes, sounds good, I'll send a patch right now (+ I don't think parsing is a problem here).
[-- Attachment #2: Type: text/html, Size: 871 bytes --]
prev parent reply other threads:[~2023-10-23 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 8:12 Gabriel Goller
2023-10-11 11:06 ` Gabriel Goller
2023-10-18 17:22 ` Thomas Lamprecht
2023-10-23 7:51 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5bde31e-1fbd-4b82-be21-a8c742781fea@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox