From: Christian Ebner <c.ebner@proxmox.com>
To: Robert Obkircher <r.obkircher@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH v2 proxmox-backup 0/2] minor chunk insert improvements
Date: Fri, 28 Aug 2026 10:10:58 +0200 [thread overview]
Message-ID: <f5394083-6c5d-4d68-89b3-2256adb4087c@proxmox.com> (raw)
In-Reply-To: <20260812135843.236667-1-r.obkircher@proxmox.com>
On 8/12/26 3:58 PM, Robert Obkircher wrote:
> Improve error messages and avoid custom unsafe code.
>
> Changes since [v1]:
> * improve error messages as suggested by @Chris
> * mention "magic number"
> * reprase to "verify and garbage-collect"
>
> [v1] https://lore.proxmox.com/pbs-devel/20260807095803.3051-1-r.obkircher@proxmox.com/
>
> Robert Obkircher (2):
> datastore: prefer standard library over custom unsafe code
> datastore: rephrase error messages for failed chunk insert
>
> pbs-datastore/src/chunk_store.rs | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
Acked-by: Christian Ebner <c.ebner@proxmox.com>
prev parent reply other threads:[~2026-08-28 8:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 13:58 [PATCH v2 proxmox-backup 0/2] minor chunk insert improvements Robert Obkircher
2026-08-12 13:58 ` [PATCH v2 proxmox-backup 1/2] datastore: prefer standard library over custom unsafe code Robert Obkircher
2026-08-12 13:58 ` [PATCH v2 proxmox-backup 2/2] datastore: rephrase error messages for failed chunk insert Robert Obkircher
2026-08-28 8:10 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5394083-6c5d-4d68-89b3-2256adb4087c@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=r.obkircher@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox