Re: [pbs-devel] [PATCH proxmox-backup 2/2] fix #5188: gui: add copy to clipboard on snapshots

[Dominik Csapak <d.csapak@proxmox.com>]

same comment as the previous patch, some note about why async is
ok would be nice

one high level comment:

i'd probably rename the button from 'copy' to something like 'copy name to clipboard'

otherwise it can be confusing as to what the button does, since 'copy' could
also mean duplicate the snapshot ;)

rest of the patch LGTM

On 3/13/24 17:17, Gabriel Goller wrote:
> When navigating to Datastores -> Content, it is now possible to
> right-click on a snapshot/group and copy the name to the clipboard.
> This makes the proxmox-backup-client much easier to use, especially when
> restoring archives.
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>   www/datastore/Content.js | 25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
> 
> diff --git a/www/datastore/Content.js b/www/datastore/Content.js
> index fa0b7d2c..b2d6a053 100644
> --- a/www/datastore/Content.js
> +++ b/www/datastore/Content.js
> @@ -546,6 +546,10 @@ Ext.define('PBS.DataStoreContent', {
>   	    });
>   	},
>   
> +	onCopy: async function(view, rI, cI, item, e, { data }) {
> +	    await navigator.clipboard.writeText(data.text);
> +	},
> +
>   	onNotesEdit: function(view, data) {
>   	    let me = this;
>   
> @@ -884,6 +888,7 @@ Ext.define('PBS.DataStoreContent', {
>   	    if (record.data.ty === 'group') {
>   		menu = Ext.create('PBS.datastore.GroupCmdMenu', {
>   		    title: gettext('Group'),
> +		    onCopy: createControllerCallback('onCopy'),
>   		    onVerify: createControllerCallback('onVerify'),
>   		    onChangeOwner: createControllerCallback('onChangeOwner'),
>   		    onPrune: createControllerCallback('onPrune'),
> @@ -892,6 +897,7 @@ Ext.define('PBS.DataStoreContent', {
>   	    } else if (record.data.ty === 'dir') {
>   		menu = Ext.create('PBS.datastore.SnapshotCmdMenu', {
>   		    title: gettext('Snapshot'),
> +		    onCopy: createControllerCallback('onCopy'),
>   		    onVerify: createControllerCallback('onVerify'),
>   		    onProtectionChange: createControllerCallback('onProtectionChange'),
>   		    onForget: createControllerCallback('onForget'),
> @@ -1284,12 +1290,21 @@ Ext.define('PBS.datastore.GroupCmdMenu', {
>       extend: 'Ext.menu.Menu',
>       mixins: ['Proxmox.Mixin.CBind'],
>   
> +    onCopy: undefined,
>       onVerify: undefined,
>       onChangeOwner: undefined,
>       onPrune: undefined,
>       onForget: undefined,
>   
>       items: [
> +	{
> +	    text: gettext('Copy'),
> +	    iconCls: 'fa fa-clipboard',
> +	    handler: function() { this.up('menu').onCopy(); },
> +	    cbind: {
> +		hidden: '{!onCopy}',
> +	    },
> +	},
>   	{
>   	    text: gettext('Verify'),
>   	    iconCls: 'pve-icon-verify-lettering',
> @@ -1330,11 +1345,21 @@ Ext.define('PBS.datastore.SnapshotCmdMenu', {
>       extend: 'Ext.menu.Menu',
>       mixins: ['Proxmox.Mixin.CBind'],
>   
> +    onCopy: undefined,
>       onVerify: undefined,
>       onProtectionChange: undefined,
>       onForget: undefined,
>   
>       items: [
> +	{
> +	    text: gettext('Copy'),
> +	    iconCls: 'fa fa-clipboard',
> +	    handler: function() { this.up('menu').onCopy(); },
> +	    cbind: {
> +		hidden: '{!onCopy}',
> +		disabled: '{!onCopy}',
> +	    },
> +	},
>   	{
>   	    text: gettext('Verify'),
>   	    iconCls: 'pve-icon-verify-lettering',