From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: fix calendarevent examples
Date: Wed, 9 Sep 2020 19:04:23 +0200 [thread overview]
Message-ID: <f3f72322-584b-9823-8e7c-584087353400@proxmox.com> (raw)
In-Reply-To: <20200909141748.10106-1-d.csapak@proxmox.com>
On 09.09.20 16:17, Dominik Csapak wrote:
> */x is not valid syntax, also an timespec must at least have
> hours and minutes
PVE supports this (and, IIRC, this parser previously too)
https://git.proxmox.com/?p=pve-manager.git;a=blob;f=www/manager6/form/CalendarEvent.js;h=c3b9ecab7e00014bd50533056e4dc9642fdf435a;hb=HEAD
I'd like if those are kept as compatible as possible, it's really
not good if we have two similar looking schedule formats which are
incompatible...
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/form/CalendarEvent.js | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/www/form/CalendarEvent.js b/www/form/CalendarEvent.js
> index d05136b9..ddc8fa79 100644
> --- a/www/form/CalendarEvent.js
> +++ b/www/form/CalendarEvent.js
> @@ -4,9 +4,9 @@ Ext.define('PBS.data.CalendarEventExamples', {
>
> field: ['value', 'text'],
> data: [
> - { value: '*/30', text: Ext.String.format(gettext("Every {0} minutes"), 30) },
> + { value: '*:0/30', text: Ext.String.format(gettext("Every {0} minutes"), 30) },
> { value: 'hourly', text: gettext("Every hour") },
> - { value: '*/2:00', text: gettext("Every two hours") },
> + { value: '0/2:00', text: gettext("Every two hours") },
> { value: '2,22:30', text: gettext("Every day") + " 02:30, 22:30" },
> { value: 'daily', text: gettext("Every day") + " 00:00" },
> { value: 'mon..fri', text: gettext("Monday to Friday") + " 00:00" },
>
prev parent reply other threads:[~2020-09-09 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 14:17 Dominik Csapak
2020-09-09 17:04 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3f72322-584b-9823-8e7c-584087353400@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox