Re: [pbs-devel] [PATCH proxmox{, -backup} v4 0/8] trigger sync jobs on mount

[Christian Ebner <c.ebner@proxmox.com>]

On 7/16/25 4:52 PM, Hannes Laimer wrote:
> Sync jobs now have a run-on-mount flag, that, if set, runs the job whenever
> a relevant removable datastore is mounted.
> 
> changes since v3, thanks @Chris:
> - wrap potentially blocking call to mount function in .spawn_blocking(||
>    ...)
> - ui: improve task title, delete `run-on-mount` flag iff `false`
> - docs: add section about `run-on-mount` flag
> - some minor things(typos, move stuff out of loop)
> - rebased onto master
> - ui: fixed formatting with `proxmox-biome`

A few more comments on some individual patches, but nothing big.
Other than that consider:

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>

Tested the following:
- Sync jobs are executed when the config flag is set
- The order of the executed sync jobs is alphabetical
- The run-on-mount flag is cleared from the config when uncheck
- The mount command via cli behaves the same as mounting via ui/api


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel