From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH widget-toolkit/proxmox-backup] adapt to stricter api parameter checks
Date: Thu, 7 Mar 2024 10:32:51 +0100 [thread overview]
Message-ID: <f31f87f8-73ec-4101-a9d7-8a2d54499f8d@proxmox.com> (raw)
In-Reply-To: <20240306112104.2486728-1-d.csapak@proxmox.com>
Am 06/03/2024 um 12:20 schrieb Dominik Csapak:
> since a bit, i believe commit
> bae2cf75 (schema: AllOf/OneOf: actually perform additional_properties() check)
>
> in proxmox-schema, sending additional properties not defined for an api
> call is forbidden and leads to an error.
>
> Sadly, the gui did not adhere strictly to the api definition and
> sometimes sent more data that what was defined, now resulting in various
> api errors when using the gui.
>
> This series fixes those that i found (there are probably some that i
> missed).
>
> I did not include the whole detail why in every commit, but if that's
> preferred just holler and i add a sentence or two to every commmit.
>
> the first patch in proxmox-backup is just indentation cleanup and not
> really related, so could be applied independently.
>
> proxmox-widget-toolkit:
>
> Dominik Csapak (1):
> realms: don't send type and delete on creation
>
> src/window/AuthEditLDAP.js | 8 ++++----
> src/window/AuthEditOpenId.js | 10 ----------
> 2 files changed, 4 insertions(+), 14 deletions(-)
>
> proxmox-backup:
>
> Dominik Csapak (6):
> ui: prune job edit: indent fix
> ui: metrics: don't send digest when creating a new influxdbupd host
> ui: tape backup job: don't send delete value on creation
> ui: prune: fix sending invalid parameters
> ui: sync job: don't send delete value on creation
> ui: verify job: don't send delete value on creation
>
> www/datastore/Content.js | 1 +
> www/panel/PrunePanel.js | 2 +-
> www/tape/window/TapeBackupJob.js | 14 ++++++++++++++
> www/window/InfluxDbEdit.js | 20 +++++++++++---------
> www/window/PruneJobEdit.js | 11 ++++++++---
> www/window/SyncJobEdit.js | 14 +++++++++++++-
> www/window/VerifyJobEdit.js | 4 +++-
> 7 files changed, 51 insertions(+), 15 deletions(-)
>
applied-series, thanks!
prev parent reply other threads:[~2024-03-07 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 11:20 [pbs-devel] " Dominik Csapak
2024-03-06 11:20 ` [pbs-devel] [PATCH widget-toolkit 1/1] realms: don't send type and delete on creation Dominik Csapak
2024-03-06 11:20 ` [pbs-devel] [PATCH proxmox-backup 1/6] ui: prune job edit: indent fix Dominik Csapak
2024-03-06 11:21 ` [pbs-devel] [PATCH proxmox-backup 2/6] ui: metrics: don't send digest when creating a new influxdbupd host Dominik Csapak
2024-03-06 11:21 ` [pbs-devel] [PATCH proxmox-backup 3/6] ui: tape backup job: don't send delete value on creation Dominik Csapak
2024-03-06 11:21 ` [pbs-devel] [PATCH proxmox-backup 4/6] ui: prune: fix sending invalid parameters Dominik Csapak
2024-03-06 11:21 ` [pbs-devel] [PATCH proxmox-backup 5/6] ui: sync job: don't send delete value on creation Dominik Csapak
2024-03-06 11:21 ` [pbs-devel] [PATCH proxmox-backup 6/6] ui: verify " Dominik Csapak
2024-03-07 9:32 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f31f87f8-73ec-4101-a9d7-8a2d54499f8d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox