From: Dominik Csapak <d.csapak@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH widget-toolkit] fix #4961: disks: increase timeout to 1min
Date: Tue, 26 Sep 2023 10:15:09 +0200 [thread overview]
Message-ID: <f31588c3-5dba-47f8-a140-d015d0a0456c@proxmox.com> (raw)
In-Reply-To: <1695714131.wbzdf9yjca.astroid@yuna.none>
On 9/26/23 09:55, Fabian Grünbichler wrote:
> On September 21, 2023 10:21 am, Gabriel Goller wrote:
>> Increase the timeout of the api call to `../nodes/localhost/disks/list`
>> to 1min. When having a lot of disks the default timeout of 30sec is
>> not enough.
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>> src/panel/DiskList.js | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/src/panel/DiskList.js b/src/panel/DiskList.js
>> index c5a0050..5785297 100644
>> --- a/src/panel/DiskList.js
>> +++ b/src/panel/DiskList.js
>> @@ -70,6 +70,7 @@ Ext.define('Proxmox.DiskList', {
>> type: 'proxmox',
>> extraParams: extraParams,
>> url: url,
>> + timeout: 60*1000,
>
> that alone won't be enough, since we also have a 30s timeout for
> proxying requests in a PVE cluster (and this component is used there).
it would actually be enough to fix that exact bug, which is for pbs
where we don't have the 30s proxy limit, but you're right it's not
a generic fix across both products
imho we could still apply this here (maybe with a short test to
see if it doesn't make the situation worse for pve) so it's fixed
for pbs at least and can properly fix it for pve later still
next prev parent reply other threads:[~2023-09-26 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 8:21 Gabriel Goller
2023-09-26 7:55 ` Fabian Grünbichler
2023-09-26 8:15 ` Dominik Csapak [this message]
2023-09-26 13:42 ` Thomas Lamprecht
2023-09-28 12:57 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f31588c3-5dba-47f8-a140-d015d0a0456c@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox