From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] log: retrieve `ReaderEnvironment` debug flag from tracing
Date: Tue, 16 Jul 2024 10:38:26 +0200 [thread overview]
Message-ID: <f2f43024-2ca6-4931-9889-ca98ad2aa2ae@proxmox.com> (raw)
In-Reply-To: <f166e0f4-ae95-415e-8bf7-c150473f6d35@proxmox.com>
On 7/16/24 10:21, Christian Ebner wrote:
>
> This is indeed a bit odd: The fact that the client can set the `debug`
> flag when upgrading to the backup protocol, but cannot and should not
> control the filter level makes this a bit strange.
>
> So I would suggest to rename this method to something like
> `client_debug` (or something better fitting?) an instead of calling the
> `info` macro directly, call `self.log` instead if `self.debug` is set.
> By this, it should at least be a bit more clear what is going on and one
> cannot accidentally loose these debug messages as the same codepath is
> then used for generating the event.
>
Forgot to mention that by having a `debug` and a `client_debug` method,
it would also be possible to differentiate log events generated by
client request and ones only by level set for the server.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-07-16 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 15:13 Gabriel Goller
2024-07-16 8:21 ` Christian Ebner
2024-07-16 8:38 ` Christian Ebner [this message]
2024-07-16 9:07 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2f43024-2ca6-4931-9889-ca98ad2aa2ae@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox