From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v6 3/6] pbs-datastore: add active operations tracking
Date: Thu, 3 Feb 2022 11:53:32 +0100 [thread overview]
Message-ID: <f2c46834-9e6d-5b49-f521-92a026046368@proxmox.com> (raw)
In-Reply-To: <20220202154927.30572-4-h.laimer@proxmox.com>
[..snip..]
On 2/2/22 16:49, Hannes Laimer wrote:
> +impl Clone for DataStore {
> + fn clone(&self) -> Self {
> + if let Some(operation) = self.operation.clone() {
> + if let Err(e) = update_active_operations(self.name(), operation, -1) {
this must have '1' instead of '-1' else a lookup + clone makes it look like
no operation is running and dropping both, leaves the counter at -2
> + eprintln!("could not update active operations - {}", e);
> + }
> + }
> + DataStore {
> + inner: self.inner.clone(),
> + operation: self.operation.clone(),
> + }
> + }
> +}
> +
> +impl Drop for DataStore {
> + fn drop(&mut self) {
> + if let Some(operation) = self.operation.clone() {
> + if let Err(e) = update_active_operations(self.name(), operation, -1) {
> + eprintln!("could not update active operations - {}", e);
> + }
> + }
> + }
> +}
> +
[..snip..]
next prev parent reply other threads:[~2022-02-03 10:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 15:49 [pbs-devel] [PATCH proxmox-backup v6 0/6] closes #3071: maintenance mode for datastore Hannes Laimer
2022-02-02 15:49 ` [pbs-devel] [PATCH proxmox-backup v6 1/6] api-types: add maintenance type Hannes Laimer
2022-02-02 15:49 ` [pbs-devel] [PATCH proxmox-backup v6 2/6] datastore: add check for maintenance in lookup Hannes Laimer
2022-02-02 15:49 ` [pbs-devel] [PATCH proxmox-backup v6 3/6] pbs-datastore: add active operations tracking Hannes Laimer
2022-02-03 10:53 ` Dominik Csapak [this message]
2022-02-02 15:49 ` [pbs-devel] [PATCH proxmox-backup v6 4/6] api: make maintenance_type updatable Hannes Laimer
2022-02-02 15:49 ` [pbs-devel] [PATCH proxmox-backup v6 5/6] api: add get_active_operations endpoint Hannes Laimer
2022-02-02 15:49 ` [pbs-devel] [PATCH proxmox-backup v6 6/6] ui: add option to change the maintenance type Hannes Laimer
2022-02-03 10:53 ` Dominik Csapak
2022-02-03 10:53 ` [pbs-devel] [PATCH proxmox-backup v6 0/6] closes #3071: maintenance mode for datastore Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2c46834-9e6d-5b49-f521-92a026046368@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox