public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] docs: client: mention missing catalog for split archives
@ 2024-07-15 14:42 Christian Ebner
  2024-07-16  8:44 ` Gabriel Goller
  0 siblings, 1 reply; 3+ messages in thread
From: Christian Ebner @ 2024-07-15 14:42 UTC (permalink / raw)
  To: pbs-devel

Adds a note informing the users that the catalog is not encoded for
change detection modes set to `data` or `metadata`, and mention to
mount the snapshot archive as alternative for inspecting the content.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 docs/backup-client.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/docs/backup-client.rst b/docs/backup-client.rst
index e56e0625b..ca054a762 100644
--- a/docs/backup-client.rst
+++ b/docs/backup-client.rst
@@ -339,6 +339,13 @@ mode:
 
     # proxmox-backup-client backup.pxar:./linux --change-detection-mode=metadata
 
+.. Note:: Backup snapshots create with ``change-detection-mode`` set to ``data``
+  or ``metadata`` do not encode a dedicated catalog, as the metadata archive
+  already contains the same information in a quickly accessible manner.
+  Therefore, the ``proxmox-backup-client catalog`` commands are not available
+  for these snapshots, ``proxmox-backup-client mount`` can be used instead to
+  mount and inspect these snapshots.
+
 .. _client_encryption:
 
 Encryption
-- 
2.39.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pbs-devel] [PATCH proxmox-backup] docs: client: mention missing catalog for split archives
  2024-07-15 14:42 [pbs-devel] [PATCH proxmox-backup] docs: client: mention missing catalog for split archives Christian Ebner
@ 2024-07-16  8:44 ` Gabriel Goller
  2024-07-16  9:07   ` Christian Ebner
  0 siblings, 1 reply; 3+ messages in thread
From: Gabriel Goller @ 2024-07-16  8:44 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion

On 15.07.2024 16:42, Christian Ebner wrote:
>Adds a note informing the users that the catalog is not encoded for
>change detection modes set to `data` or `metadata`, and mention to
>mount the snapshot archive as alternative for inspecting the content.
>
>Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>---
> docs/backup-client.rst | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/docs/backup-client.rst b/docs/backup-client.rst
>index e56e0625b..ca054a762 100644
>--- a/docs/backup-client.rst
>+++ b/docs/backup-client.rst
>@@ -339,6 +339,13 @@ mode:
>
>     # proxmox-backup-client backup.pxar:./linux --change-detection-mode=metadata
>
>+.. Note:: Backup snapshots create with ``change-detection-mode`` set to ``data``

s/create/created/

>+  or ``metadata`` do not encode a dedicated catalog, as the metadata archive
>+  already contains the same information in a quickly accessible manner.
>+  Therefore, the ``proxmox-backup-client catalog`` commands are not available
>+  for these snapshots, ``proxmox-backup-client mount`` can be used instead to

                         ^
                         maybe insert 'and' instead of the comma?

>+  mount and inspect these snapshots.

                       ^
                      s/these snapshots/them/

>+
> .. _client_encryption:
>
> Encryption

Otherwise LGTM!



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pbs-devel] [PATCH proxmox-backup] docs: client: mention missing catalog for split archives
  2024-07-16  8:44 ` Gabriel Goller
@ 2024-07-16  9:07   ` Christian Ebner
  0 siblings, 0 replies; 3+ messages in thread
From: Christian Ebner @ 2024-07-16  9:07 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Gabriel Goller

Thanks for having a look at this Gabriel!

However the decision was made to instead implement the catalog commands 
for the split pxar case as well, by using the information provided by 
the metadata archive instead of the catalog.

Therefore, please ignore this patch.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-16  9:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-15 14:42 [pbs-devel] [PATCH proxmox-backup] docs: client: mention missing catalog for split archives Christian Ebner
2024-07-16  8:44 ` Gabriel Goller
2024-07-16  9:07   ` Christian Ebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal