From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] node: status: added bootmode
Date: Fri, 24 Nov 2023 10:11:03 +0100 [thread overview]
Message-ID: <f1c8781c-c3cd-4c35-a9cb-7e0a889dfe9f@proxmox.com> (raw)
In-Reply-To: <1c183e8d-ea2a-45b5-8929-cec5a02a6e89@proxmox.com>
Am 24/11/2023 um 10:04 schrieb Gabriel Goller:
>> please move above into it's own helper method, it could even live in
>> some more common module (but we can still move it later, so no hard
>> feelings on that).
> How about we move it to proxmox-sys?
That crate is already to huge and is in serious needs of getting split
up as it blows up compile times for smaller projects that need only a
few bits of it, so that's why I avoided the suggestion.
But not to hard feelings for now, it'd won't get that much worse and
having it there might allow for a better decision about how to split
it, just don't shove it into some random overly general module.
next prev parent reply other threads:[~2023-11-24 9:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 13:09 [pbs-devel] [PATCH proxmox-backup 0/2] Add bootmode, improve kernel version Gabriel Goller
2023-11-23 13:09 ` [pbs-devel] [PATCH proxmox-backup 1/2] node: status: added bootmode Gabriel Goller
2023-11-23 16:32 ` Thomas Lamprecht
2023-11-24 9:04 ` Gabriel Goller
2023-11-24 9:11 ` Thomas Lamprecht [this message]
2023-11-23 13:09 ` [pbs-devel] [PATCH proxmox-backup 2/2] node: status: declutter kernel-version Gabriel Goller
2023-11-23 16:15 ` Dietmar Maurer
2023-11-23 16:29 ` Thomas Lamprecht
2023-11-23 16:35 ` Thomas Lamprecht
2023-11-24 9:13 ` Gabriel Goller
2023-11-23 16:28 ` Thomas Lamprecht
2023-11-24 12:02 ` [pbs-devel] [PATCH proxmox-backup 0/2] Add bootmode, improve kernel version Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1c8781c-c3cd-4c35-a9cb-7e0a889dfe9f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox