From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/2] debug cli: improve output, optionally compare file content for `diff archive`
Date: Thu, 1 Dec 2022 14:29:18 +0100 [thread overview]
Message-ID: <f0b6ea65-48b5-8f83-1a3e-0da52d2e1bee@proxmox.com> (raw)
In-Reply-To: <20221129141730.740199-1-l.wagner@proxmox.com>
[-- Attachment #1: Type: text/plain, Size: 2695 bytes --]
I reviewed this by generating 100 random files via the following command:
seq -w 1 100 | xargs -n1 -I% sh -c 'dd if=/dev/urandom of=file.%
bs=$(shuf -i1-10 -n1) count=1024'
Then I created a backup from those files, recreated the files with the
above command and created a second backup.
Additionally I created a 3rd backup where I:
* changed uid & gid of 10 files
* changed permissions of 10 files
* deleted 10 files
* created 10 new files
* moved some of the files into a new subdirectory
* touched 10 files
All changes between 1 ->2 and 2 -> 3 and 1 -> 3 were picked up by the
diff tool as far as I could tell.
Some files where the content has changed but everything else stayed the
same (except for mtime), were not marked as changed without the flag
--compare-content. Maybe we should not mark any files as changed without
the --compare-content flag or we should mark all files as changed where
any attribute changed?
With --compare-content the changes were picked up, which is what this
flag is for, so I think it's OK.
Code LGTM!
Reviewed-by: Stefan Hanreich <s.hanreich@proxmox.com>
Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>
On 11/29/22 15:17, Lukas Wagner wrote:
> This patch series contains a few improvements for the `diff archive` tool,
> mainly based on Wolfgang's suggestions.
>
> First, the output of is now much more detailed and shows
> some relevant file attributes, including what has changed between
> snapshots. Changed attributes are highlighted by a "*".
>
> For instance:
>
> $ proxmox-backup-debug diff archive ...
> A f 644 10045 10000 0 B 2022-11-28 13:44:51 add.txt
> M f 644 10045 10000 6 B *2022-11-28 13:45:05 content.txt
> D f 644 10045 10000 0 B 2022-11-28 13:17:09 deleted.txt
> M f 644 10045 *29 0 B 2022-11-28 13:16:20 gid.txt
> M f *777 10045 10000 0 B 2022-11-28 13:42:47 mode.txt
> M f 644 10045 10000 0 B *2022-11-28 13:44:33 mtime.txt
> M f 644 10045 10000 *7 B *2022-11-28 13:44:59 *size.txt
> M f 644 *64045 10000 0 B 2022-11-28 13:16:18 uid.txt
> M *f 644 10045 10000 10 B 2022-11-28 13:44:59 type.txt
>
> The second commit introduces the possiblity to pass
> the --compare-content flag to the tool. If the flag is passed,
> the tool will compare the file content instead of relying on mtime
> alone to detect modifications.
>
> Lukas Wagner (2):
> debug cli: show more file attributes for `diff archive` command
> debug cli: add 'compare-content' flag to `diff archive` command
>
> src/bin/proxmox_backup_debug/diff.rs | 356 ++++++++++++++++++++++-----
> 1 file changed, 299 insertions(+), 57 deletions(-)
>
[-- Attachment #2: Type: text/html, Size: 3499 bytes --]
prev parent reply other threads:[~2022-12-01 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 14:17 Lukas Wagner
2022-11-29 14:17 ` [pbs-devel] [PATCH proxmox-backup 1/2] debug cli: show more file attributes for `diff archive` command Lukas Wagner
2022-11-29 14:17 ` [pbs-devel] [PATCH proxmox-backup 2/2] debug cli: add 'compare-content' flag to " Lukas Wagner
2022-12-01 13:29 ` Stefan Hanreich
2022-12-01 13:30 ` Stefan Hanreich
2022-11-30 16:27 ` [pbs-devel] [PATCH proxmox-backup 0/2] debug cli: improve output, optionally compare file content for `diff archive` Thomas Lamprecht
2022-12-01 7:30 ` Lukas Wagner
2022-12-01 8:02 ` Thomas Lamprecht
2022-12-01 13:29 ` Stefan Hanreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0b6ea65-48b5-8f83-1a3e-0da52d2e1bee@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox