From: Gabriel Goller <g.goller@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 3/3] node: status: declutter kernel-version
Date: Mon, 27 Nov 2023 09:35:07 +0100 [thread overview]
Message-ID: <f097b904-cc97-4185-9b59-b3c3f2c2402a@proxmox.com> (raw)
In-Reply-To: <ea042841-a0c0-4563-9203-e61ac59289ab@proxmox.com>
Thanks for the review!
On 11/24/23 15:19, Lukas Wagner wrote:
> Hi, some comments inline :)
>
> On 11/24/23 13:02, Gabriel Goller wrote:
>>
>> diff --git a/www/panel/NodeInfo.js b/www/panel/NodeInfo.js
>> index 14f84a2e..b1e4ece2 100644
>> --- a/www/panel/NodeInfo.js
>> +++ b/www/panel/NodeInfo.js
>> @@ -140,11 +140,20 @@ Ext.define('PBS.NodeInfoPanel', {
>> value: '',
>> },
>> {
>> - itemId: 'kversion',
>> colspan: 2,
>> title: gettext('Kernel Version'),
>> printBar: false,
>> - textField: 'kversion',
>> + // TODO: remove with next major and only use newish
>> current-kernel textfield
>> + multiField: true,
>> + //textField: 'current-kernel',
> I guess this is not needed?
Not currently, as we return both the legacy *and* the new field. As we
release the next
major version, we will remove the `multiField: true` and uncommment the
`textField` property.
Same as it has been done in pve.
>
>> + renderer: ({ data }) => {
>> + if (!data['current-kernel']) {
>> + return data.kversion;
>> + }
>> + let kernel = data['current-kernel'];
>> + let buildDate =
>> kernel.version.match(/\((.+)\)\s*$/)[1] ?? 'unknown';
>> + return `${kernel.sysname} ${kernel.release}
>> (${buildDate})`;
>
> Identation is off here, spaces instead of tabs+spaces
Right! Thanks for the heads up!
>
>> + },
>> value: '',
>> },
>> {
>
next prev parent reply other threads:[~2023-11-27 8:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 12:02 [pbs-devel] [PATCH v2 proxmox{-backup, } 0/3] Add boot_mode, improve kernel version Gabriel Goller
2023-11-24 12:02 ` [pbs-devel] [PATCH v2 proxmox 1/3] sys: add function to get boot_mode Gabriel Goller
2023-11-24 14:19 ` Lukas Wagner
2023-11-24 12:02 ` [pbs-devel] [PATCH v2 proxmox-backup 2/3] node: status: added bootmode Gabriel Goller
2023-11-24 14:20 ` Lukas Wagner
2023-11-27 8:26 ` Gabriel Goller
2023-11-27 8:32 ` Lukas Wagner
2023-11-24 12:02 ` [pbs-devel] [PATCH v2 proxmox-backup 3/3] node: status: declutter kernel-version Gabriel Goller
2023-11-24 14:19 ` Lukas Wagner
2023-11-27 8:35 ` Gabriel Goller [this message]
2023-11-24 14:18 ` [pbs-devel] [PATCH v2 proxmox{-backup, } 0/3] Add boot_mode, improve kernel version Lukas Wagner
2023-11-24 14:45 ` Thomas Lamprecht
2023-11-27 8:41 ` Gabriel Goller
2023-11-27 8:56 ` Gabriel Goller
2023-11-27 9:13 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f097b904-cc97-4185-9b59-b3c3f2c2402a@proxmox.com \
--to=g.goller@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox