Re: [pbs-devel] [PATCH proxmox] lang: Remove offsetof macro

[Christian Ebner <c.ebner@proxmox.com>]

On 1/26/26 3:11 PM, Maximiliano Sandoval wrote:
> With rust 1.90 this will crash while running cargo test with
> 
> $ RUST_BACKTRACE=1 cargo test
> 
> null pointer dereference occurred
> stack backtrace:
>     0: __rustc::rust_begin_unwind
>               at /usr/src/rustc-1.90.0/library/std/src/panicking.rs:697:5
>     1: core::panicking::panic_nounwind_fmt::runtime
>               at /usr/src/rustc-1.90.0/library/core/src/panicking.rs:117:22
>     2: core::panicking::panic_nounwind_fmt
>               at /usr/src/rustc-1.90.0/library/core/src/intrinsics/mod.rs:2367:9
>     3: core::panicking::panic_null_pointer_dereference
>               at /usr/src/rustc-1.90.0/library/core/src/panicking.rs:311:5
>     4: rust_out::main::_doctest_main_proxmox_lang_src_lib_rs_71_0
>     5: rust_out::main
>     6: core::ops::function::FnOnce::call_once
> 
> Note that the deref_nullptr lint is going to be denied by default on 1.93.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> As far as my greeping was able to tell, there should be no other users than the
> docstring.

Could not find any remaining users in our codebase as well, and since 
this macro has been deprecated since June 2024 according to the debian 
changelog, any remaining users should have already been moved to 
`std::mem::offset_of!` replacement anyways.

Therefore consider:

Acked-by: Christian Ebner <c.ebner@proxmox.com>