public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Stefan Sterz <s.sterz@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] pbs-config: acl-tree: add any_priv_below
Date: Tue, 7 Jun 2022 08:23:24 +0200	[thread overview]
Message-ID: <ef9661d0-7781-ff55-1a4a-2e04912046c9@proxmox.com> (raw)
In-Reply-To: <20220603153224.476172-1-s.sterz@proxmox.com>

Am 03/06/2022 um 17:32 schrieb Stefan Sterz:
> `any_priv_below()` checks if a given AuthId has any given privileges
> on a sub-tree of the AclTree. to do so, it first takes into account
> propagating privileges on the path itself and then uses a depth-first
> search to check if any of the provided privileges are set on any
> node of the sub-tree pointed to by the path.
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>  pbs-config/src/acl.rs | 122 +++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 120 insertions(+), 2 deletions(-)
> 
>

applied, thanks! made a few small follow ups though, but mostly changing parameter
names and some small styling stuff, so nothing changed in the actual implementation.

And I put this to use for replacing the not so nice ns-iteration and one by one
checking for an Ok priv, making it faster and irrelevant for maintenance operations,
which is nice to have for UI-crucial API endpoints.




      reply	other threads:[~2022-06-07  6:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 15:32 [pbs-devel] " Stefan Sterz
2022-06-07  6:23 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef9661d0-7781-ff55-1a4a-2e04912046c9@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal