From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 4/5] ui: datastore/Summary: change storage axis to power of two
Date: Tue, 17 May 2022 10:20:43 +0200 [thread overview]
Message-ID: <ef082bbd-c673-3530-14fd-6fa73c68ea36@proxmox.com> (raw)
In-Reply-To: <93d352ce-fe3c-7eee-4b07-b217df86b376@proxmox.com>
On 5/17/22 10:09, Thomas Lamprecht wrote:
> Am 5/17/22 um 08:52 schrieb Dominik Csapak:
>> so that the unit is the same as in the overview panel on the same page
>>
>
> This missed the administration Server Status RRD for the root disk, but actually
> this needs to be the other way around, I switched to power of two for all memory
> graphs in PVE 7.0 and the storage one to power of ten, at least the pve storages,
> the root HD one in the node summary is still wrong (will fix).
>
>
yeah you're right, i forgot about the administration rrd panels.
any reason why we use different units for disk vs memory?
imho storage also often uses binary units.
(`lvs`/`lsblk` uses that in it's default output, we use it
for vm/ct disks, etc.)
next prev parent reply other threads:[~2022-05-17 8:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 6:52 [pbs-devel] [PATCH proxmox-backup 1/5] tape/pool_writer: give proper types to 'contains_snapshot' Dominik Csapak
2022-05-17 6:52 ` [pbs-devel] [PATCH proxmox-backup 2/5] ui: form/NamespaceSelector: show proper emptyText Dominik Csapak
2022-05-17 11:41 ` [pbs-devel] applied: " Thomas Lamprecht
2022-05-17 6:52 ` [pbs-devel] [PATCH proxmox-backup 3/5] ui: form/DataStoreSelector: show maintenance mode in selector Dominik Csapak
2022-05-17 8:53 ` [pbs-devel] applied: " Thomas Lamprecht
2022-05-17 6:52 ` [pbs-devel] [PATCH proxmox-backup 4/5] ui: datastore/Summary: change storage axis to power of two Dominik Csapak
2022-05-17 8:09 ` Thomas Lamprecht
2022-05-17 8:20 ` Dominik Csapak [this message]
2022-05-17 8:32 ` Thomas Lamprecht
2022-05-17 6:52 ` [pbs-devel] [PATCH proxmox-backup 5/5] ui: SyncView/SyncJobEdit: unify store/namespace gettext Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef082bbd-c673-3530-14fd-6fa73c68ea36@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox