From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup stable-3 0/3] Backport group listing optimizations including bugfix
Date: Mon, 27 Oct 2025 11:24:24 +0100 [thread overview]
Message-ID: <ed42e3e1-e12a-4038-af46-8970bf72df2b@proxmox.com> (raw)
In-Reply-To: <535e3159-7081-4b37-865d-92f89fa56e9e@proxmox.com>
On 10/27/25 11:21 AM, Thomas Lamprecht wrote:
> Am 27.10.25 um 10:33 schrieb Christian Ebner:
>> These patches were part of the patch series to introduce the
>> streaming content api for PBS [0], optimizing the backup group
>> listing.
>>
>> They did however indirectly fix also a bug in the group listing
>> api call, which lead to the `last-backup` time to be returned
>> incorrectly in some occasions. This was found and disected in
>> issue 6956 [1], identifying an incorrect is_finished() check while
>> folding the snapshot iterator to determine the last finished snapshot
>> of a group.
>>
>> Therefore, instead of just fixing the bug, backport the relevant
>> patches which also provides the group listing improvements.
>
> They all miss your S-o-b trailer, and ideally add the original commit
> they got backported from, if you use `git -xs cherry-pick <ref>` all
> this happens automatically.
Thanks for the hint! Will resend the series as v2 with that fixed shortly.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-10-27 10:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 9:33 Christian Ebner
2025-10-27 9:33 ` [pbs-devel] [PATCH proxmox-backup stable-3 1/3] api: admin: datastore: refactor BackupGroup to GroupListItem conversion Christian Ebner
2025-10-27 9:33 ` [pbs-devel] [PATCH proxmox-backup stable-3 2/3] api: admin: datastore: factor out 'get_group_owner' Christian Ebner
2025-10-27 9:33 ` [pbs-devel] [PATCH proxmox-backup stable-3 3/3] api: admin: datastore: optimize `groups` api call Christian Ebner
2025-10-27 10:21 ` [pbs-devel] [PATCH proxmox-backup stable-3 0/3] Backport group listing optimizations including bugfix Thomas Lamprecht
2025-10-27 10:24 ` Christian Ebner [this message]
2025-10-27 16:32 ` Thomas Lamprecht
2025-10-27 10:32 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed42e3e1-e12a-4038-af46-8970bf72df2b@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox