public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Matthias Heiserer <m.heiserer@proxmox.com>
Subject: [pbs-devel] applied: [PATCH v3 proxmox-backup] prune-simulator: allow setting a custom date/time
Date: Wed, 5 Oct 2022 17:01:07 +0200	[thread overview]
Message-ID: <ed0a8b71-d7d0-ac17-8be9-efc6619d7c61@proxmox.com> (raw)
In-Reply-To: <20220920132128.380765-1-m.heiserer@proxmox.com>

Am 20/09/2022 um 15:21 schrieb Matthias Heiserer:
> With this, the prune simulator will be more flexible, which might clear
> up questions such as these:
> https://forum.proxmox.com/threads/pbs-prune-simulator-monthly-backups.115081
> 
> In order to have the configuration window not take up too much space,
> I added another column and moved the border to the left.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> Thanks to fiona for the many suggestions!
> 
> CHANGES FROM v2:
> use getDate (gives day of month) instead of getDay (day of week)
> change instead of select, and check that input is valid
> use Y-m-d in date selector to stay consistent with rest of page
> include backup happening at selected time in simulation
> slightly reworded commit message
> 
> CHANGES FROM v1:
> squash patches
> wider column so no fields are cut off
> smaller year/time labels
> use viewmodel instead of `const NOW`
> improve patch title
> 24h (hh:mm) format for time
> 
>  .../prune-simulator/prune-simulator_source.js | 151 +++++++++++++-----
>  1 file changed, 109 insertions(+), 42 deletions(-)
> 
>

applied, with Fiona's T-b and R-b tags, thanks!

I reworked the layout of the whole simulation options panel in a few follow ups though,
not really related directly to your patch, it just made me retake a closer look on the
whole thing. Please holler if something broke.




      parent reply	other threads:[~2022-10-05 15:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20 13:21 [pbs-devel] " Matthias Heiserer
2022-09-22  9:43 ` Fiona Ebner
2022-10-05 15:01 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed0a8b71-d7d0-ac17-8be9-efc6619d7c61@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.heiserer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal