From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] apt: use typed response for get_versions
Date: Thu, 12 Nov 2020 10:18:03 +0100 [thread overview]
Message-ID: <eb5fa872-c15d-b57f-4e05-6a9fd2a60539@proxmox.com> (raw)
In-Reply-To: <20201112091254.29059-1-s.reiter@proxmox.com>
On 12.11.20 10:12, Stefan Reiter wrote:
> ...and cleanup get_versions for manager CLI.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> No need to return an untyped Value, especially if we want to further work with
> it, so how about this for a cleanup?
>
> src/api2/node/apt.rs | 4 ++--
> src/bin/proxmox-backup-manager.rs | 10 ++--------
> 2 files changed, 4 insertions(+), 10 deletions(-)
>
>
much nicer, and the obvious solution; I'd guess it was a bit to late for me yesterday ^^
applied, thanks!
next prev parent reply other threads:[~2020-11-12 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 13:22 [pbs-devel] [PATCH v2 proxmox-backup 1/2] add extra_info field to APTUpdateInfo Mira Limbeck
2020-11-10 13:22 ` [pbs-devel] [PATCH v2 proxmox-backup 2/2] add versions command to proxmox-backup-manager Mira Limbeck
2020-11-11 17:38 ` [pbs-devel] applied: " Thomas Lamprecht
2020-11-12 9:12 ` [pbs-devel] [PATCH proxmox-backup] apt: use typed response for get_versions Stefan Reiter
2020-11-12 9:18 ` Thomas Lamprecht [this message]
[not found] ` <c16a8594-0f66-eadb-1063-d6309187a4e5@proxmox.com>
2020-11-12 9:29 ` [pbs-devel] applied: [PATCH v2 proxmox-backup 2/2] add versions command to proxmox-backup-manager Thomas Lamprecht
2020-11-11 11:59 ` [pbs-devel] [PATCH v2 proxmox-backup 1/2] add extra_info field to APTUpdateInfo Mira Limbeck
2020-11-11 17:33 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb5fa872-c15d-b57f-4e05-6a9fd2a60539@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox