From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] ui: tape/TapeRestore: fix restoring without mapping
Date: Thu, 8 Apr 2021 08:19:09 +0200 [thread overview]
Message-ID: <eb1e565a-ed3a-3c87-f88f-a68d35a8ed40@proxmox.com> (raw)
In-Reply-To: <20210329112537.17261-1-d.csapak@proxmox.com>
any comment?
On 3/29/21 1:25 PM, Dominik Csapak wrote:
> we have to delete the 'mapping' variable in any case since it's not
> a valid api parameter
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/tape/window/TapeRestore.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/tape/window/TapeRestore.js b/www/tape/window/TapeRestore.js
> index a9deb745..d33080e4 100644
> --- a/www/tape/window/TapeRestore.js
> +++ b/www/tape/window/TapeRestore.js
> @@ -30,8 +30,8 @@ Ext.define('PBS.TapeManagement.TapeRestoreWindow', {
>
> if (values.mapping) {
> datastores.push(values.mapping);
> - delete values.mapping;
> }
> + delete values.mapping;
>
> values.store = datastores.join(',');
>
>
prev parent reply other threads:[~2021-04-08 6:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 11:25 Dominik Csapak
2021-03-29 11:25 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape/TapeRestore: use correct value check for store & mapping Dominik Csapak
2021-04-08 6:19 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb1e565a-ed3a-3c87-f88f-a68d35a8ed40@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox